How to Contribute¶

The Hyperledger Cacti repository contains specific instructions for contributing to that project.

In this section, you will find generic instructions and guidelines for contributing to any Hyperledger project.

Ways to Contribute¶

Contributions from the development community help improve the capabilities of Hyperledger Cacti. These contributions are the most effective way to make a positive impact on the project.

Ways you can contribute:

• Bugs or issues: Report problems or defects found when working with the project (see Reporting a Bug)
• Core features and enhancements: Provide expanded capabilities or optimizations
• Documentation: Improve existing documentation or create new information
• Tests: Add functional, performance, or scalability tests

Issues can be found in GitHub. Any unassigned items are probably still open. When in doubt, ask on Discord about a specific issue (see Asking a Question). We also use the #good-first-issue tag to represent issues that might be good for first timers.

The Commit Process¶

Hyperledger Cacti is Apache 2.0 licensed and accepts contributions via GitHub pull requests. When contributing code, please follow these guidelines:

• Fork the repository and make your changes in a feature branch
• Include unit and integration tests for any new features and updates to existing tests
• Ensure that the unit and integration tests run successfully prior to submitting the pull request.

Pull Request Guidelines¶

A pull request can contain a single commit or multiple commits. The most important guideline is that a single commit should map to a single fix or enhancement. Here are some example scenarios:

• If a pull request adds a feature but also fixes two bugs, the pull request should have three commits: one commit for the feature change and two commits for the bug fixes.
• If a PR is opened with five commits that contain changes to fix a single issue, the PR should be rebased to a single commit.
• If a PR is opened with several commits, where the first commit fixes one issue and the rest fix a separate issue, the PR should be rebased to two commits (one for each issue).

Commit Messages¶

Commit messages should follow common Git conventions, such as using the imperative mood, separate subject lines, and a line length of 72 characters. These rules are well documented in Chris Beam's blog post.

Signed-off-by¶

Each commit must include a "Signed-off-by" line in the commit message (git commit -s). This sign-off indicates that you agree the commit satisfies the Developer Certificate of Origin (DCO).

Commit Email Address¶

Your commit email address must match your GitHub email address. For more information, see https://help.github.com/articles/setting-your-commit-email-address-in-git/

Important GitHub Requirements¶

A pull request cannot merged until it has passed these status checks:

• The build must pass all checks
• The PR must be approved by at least two reviewers without any outstanding requests for changes

Inclusive Language¶

• Consider that users who will read the source code and documentation are from different background and cultures and that they have different preferences.
• Avoid potential offensive terms and, for instance, prefer "allow list and deny list" to "white list and black list".
• We believe that we all have a role to play to improve our world, and even if writing inclusive code and documentation might not look like a huge improvement, it's a first step in the right direction.
• We suggest to refer to Microsoft bias free writing guidelines and Google inclusive doc writing guide as starting points.

Credits¶

This document is based on Hyperledger Sawtooth's Contributing documentation.